Skip to content

Execution Time Limit Fixes

Placeholder Jimmy Keith requested to merge 336_execution_time_limit into develop

@ mention of reviewers`

@ckcollab`

A brief description of the purpose of the changes contained in this PR.

Fixes references to execution time limit as _ms since the actual unit is seconds. Should address uploading a comp, and creating a dump. Also actually times out ingestion/scoring programs and writes their logs.

Also removes redundant buttons in user dropdown. Not strictly related to this PR, but since it is small and needed to be done, addressing it here rather than creating a new PR.

Issues this PR resolves

Resolves #366 (closed) wrong number in the branch name... oops. resolves #374 (closed)

A checklist for hand testing

  • upload a competition, and set its phase's execution time limit to something like 10 seconds.
  • upload a submission with a sleep of that length contained in it.
  • submission should terminate and the docker container should be removed.

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

Merge request reports

Loading