From 82424efe824bd10218bb7991b1f58dd0274557fb Mon Sep 17 00:00:00 2001
From: Lucas ONDEL YANG <lucas.ondel@cnrs.fr>
Date: Wed, 19 Apr 2023 13:53:56 +0200
Subject: [PATCH] replace semiring multiplication with module multiplication

---
 sandbox/autodiff.jl | 4 ++--
 src/fst.jl          | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sandbox/autodiff.jl b/sandbox/autodiff.jl
index 3d42348..a3299f1 100644
--- a/sandbox/autodiff.jl
+++ b/sandbox/autodiff.jl
@@ -109,8 +109,8 @@ begin
 		# (not the log-semiring). `val.(X)` casts `X` in the 
 		# real-semiring while `K.(...)` converts it back 
 		# to the log-semiring.
-		X1 = K.( val.(X1) + (τ ⊗ ∇X1) )
-		X2 = K.( val.(X2) + (τ ⊗ ∇X2) )
+		X1 = K.( val.(X1) + (τ * ∇X1) )
+		X2 = K.( val.(X2) + (τ * ∇X2) )
 	end
 
 	plot(F, ylabel="F", xlabel = "step", legend = false)
diff --git a/src/fst.jl b/src/fst.jl
index d755e18..eab4441 100644
--- a/src/fst.jl
+++ b/src/fst.jl
@@ -31,7 +31,7 @@ function Base.:+(A::AbstractFST, B::AbstractFST)
     FST(α(A) + α(B), T(A) + T(B), ω(A) + ω(B), ρ(A) + ρ(B), λ(A))
 end
 
-function Semirings.:⊗(x::Number, A::AbstractFST)
+function Base.:*(x::Number, A::AbstractFST)
     Q = nstates(A)
     I_α, V_α = findnz(α(A))
     I_T, J_T, V_T = findnz(T(A))
-- 
GitLab