From 41b2efd36588e15e6bac086d08e8df4cb494e9d2 Mon Sep 17 00:00:00 2001
From: Lukas Stadler <lukas.stadler@oracle.com>
Date: Tue, 7 Feb 2017 10:14:58 +0100
Subject: [PATCH] keep SuppressWarnings as precise as possible
---
.../r/engine/RRuntimeASTAccessImpl.java | 3 +-
.../truffle/r/library/stats/BinDist.java | 1 -
.../truffle/r/library/utils/ObjectSize.java | 7 ++--
.../oracle/truffle/r/library/utils/Rprof.java | 5 ++-
.../builtin/base/ConditionFunctions.java | 3 --
.../builtin/base/DuplicatedFunctions.java | 1 -
.../r/nodes/builtin/base/GrepFunctions.java | 2 --
.../r/nodes/builtin/base/ListBuiltin.java | 1 -
.../truffle/r/nodes/builtin/base/Mapply.java | 3 +-
.../truffle/r/nodes/builtin/base/Merge.java | 1 -
.../r/nodes/builtin/base/NGetText.java | 7 +---
.../truffle/r/nodes/builtin/base/Names.java | 2 --
.../builtin/base/NamespaceFunctions.java | 1 -
.../truffle/r/nodes/builtin/base/Paste.java | 1 -
.../truffle/r/nodes/builtin/base/Paste0.java | 1 -
.../truffle/r/nodes/builtin/base/Return.java | 2 --
.../r/nodes/builtin/base/SeqFunctions.java | 32 +++++++------------
.../builtin/base/SerializeFunctions.java | 1 -
.../r/nodes/builtin/base/SortFunctions.java | 1 -
.../foreign/CallAndExternalFunctions.java | 2 +-
.../builtin/base/infix/AssignBuiltin.java | 5 ++-
.../builtin/base/infix/AssignBuiltinEq.java | 5 ++-
.../base/infix/AssignOuterBuiltin.java | 5 ++-
.../builtin/base/infix/BraceBuiltin.java | 5 ++-
.../builtin/base/infix/BreakBuiltin.java | 5 ++-
.../nodes/builtin/base/infix/ForBuiltin.java | 5 ++-
.../builtin/base/infix/FunctionBuiltin.java | 5 ++-
.../r/nodes/builtin/base/infix/IfBuiltin.java | 5 ++-
.../nodes/builtin/base/infix/NextBuiltin.java | 5 ++-
.../builtin/base/infix/RepeatBuiltin.java | 5 ++-
.../r/nodes/builtin/fastr/FastRContext.java | 2 --
.../r/nodes/access/AccessSlotNode.java | 3 +-
.../r/nodes/access/BaseWriteVariableNode.java | 15 +++++----
.../nodes/access/vector/PositionCastNode.java | 7 ++--
.../vector/PositionCheckSubscriptNode.java | 3 +-
.../vector/PositionCheckSubsetNode.java | 3 +-
.../vector/RecursiveExtractSubscriptNode.java | 8 ++---
.../vector/RecursiveReplaceSubscriptNode.java | 6 ++--
.../access/vector/WriteIndexedVectorNode.java | 4 +--
.../attributes/CopyOfRegAttributesNode.java | 12 +++----
.../attributes/HasFixedAttributeNode.java | 5 ++-
.../r/nodes/attributes/SetAttributeNode.java | 5 ++-
.../r/nodes/attributes/TypeFromModeNode.java | 5 ++-
.../builtin/casts/ValueForwardingNode.java | 2 +-
.../builtin/casts/fluent/PipelineBuilder.java | 1 -
.../truffle/r/nodes/control/RLengthNode.java | 18 ++++-------
.../call/RExplicitBaseEnvCallDispatcher.java | 3 +-
.../signature/CollectArgumentsNode.java | 5 ++-
.../signature/CombineSignaturesNode.java | 12 +++----
.../truffle/r/nodes/unary/TypeofNode.java | 11 +++----
.../unary/UnaryArithmeticReduceNode.java | 2 +-
.../truffle/r/nodes/unary/UnaryNotNode.java | 1 -
.../com/oracle/truffle/r/runtime/RSrcref.java | 1 -
.../r/test/builtins/TestBuiltin_parse.java | 4 +--
54 files changed, 94 insertions(+), 171 deletions(-)
diff --git a/com.oracle.truffle.r.engine/src/com/oracle/truffle/r/engine/RRuntimeASTAccessImpl.java b/com.oracle.truffle.r.engine/src/com/oracle/truffle/r/engine/RRuntimeASTAccessImpl.java
index d244da876a..f5710f0c50 100644
--- a/com.oracle.truffle.r.engine/src/com/oracle/truffle/r/engine/RRuntimeASTAccessImpl.java
+++ b/com.oracle.truffle.r.engine/src/com/oracle/truffle/r/engine/RRuntimeASTAccessImpl.java
@@ -724,9 +724,8 @@ class RRuntimeASTAccessImpl implements RRuntimeASTAccess {
RInstrumentation.checkDebugRequested(func);
}
- @SuppressWarnings("rawtypes")
@Override
- public Class<? extends TruffleLanguage> getTruffleRLanguage() {
+ public Class<? extends TruffleLanguage<?>> getTruffleRLanguage() {
return TruffleRLanguage.class;
}
}
diff --git a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/stats/BinDist.java b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/stats/BinDist.java
index 93fb0bd2f5..a5b037c384 100644
--- a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/stats/BinDist.java
+++ b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/stats/BinDist.java
@@ -22,7 +22,6 @@ import static com.oracle.truffle.r.runtime.RError.NO_CALLER;
import java.util.Arrays;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RExternalBuiltinNode;
import com.oracle.truffle.r.runtime.RError.Message;
import com.oracle.truffle.r.runtime.RRuntime;
diff --git a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/ObjectSize.java b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/ObjectSize.java
index 46b2c62146..8c17ea3fb6 100644
--- a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/ObjectSize.java
+++ b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/ObjectSize.java
@@ -35,7 +35,6 @@ import com.oracle.truffle.r.runtime.data.RTypedValue;
* {@link RObjectSize#getObjectSize}. As per GNU R the AST size for a closure is included. TODO AST
* size not included owing to problems sizing it automatically.
*/
-@SuppressWarnings("unused")
public abstract class ObjectSize extends RExternalBuiltinNode.Arg1 {
private static class MyIgnoreObjectHandler implements RObjectSize.IgnoreObjectHandler {
@@ -52,17 +51,17 @@ public abstract class ObjectSize extends RExternalBuiltinNode.Arg1 {
private static final MyIgnoreObjectHandler ignoreObjectHandler = new MyIgnoreObjectHandler();
@Specialization
- protected int objectSize(int o) {
+ protected int objectSize(@SuppressWarnings("unused") int o) {
return RObjectSize.INT_SIZE;
}
@Specialization
- protected int objectSize(double o) {
+ protected int objectSize(@SuppressWarnings("unused") double o) {
return RObjectSize.DOUBLE_SIZE;
}
@Specialization
- protected int objectSize(byte o) {
+ protected int objectSize(@SuppressWarnings("unused") byte o) {
return RObjectSize.BYTE_SIZE;
}
diff --git a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/Rprof.java b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/Rprof.java
index ac4688363f..e91e16f85a 100644
--- a/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/Rprof.java
+++ b/com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/utils/Rprof.java
@@ -92,11 +92,10 @@ public abstract class Rprof extends RExternalBuiltinNode.Arg8 implements RDataFa
casts.arg(7, "bufsize").asIntegerVector().findFirst().mustBe(gte(0));
}
- @SuppressWarnings("unused")
@Specialization
@TruffleBoundary
- public Object doRprof(String filename, boolean append, double intervalD, boolean memProfiling,
- boolean gcProfiling, boolean lineProfiling, int numFiles, int bufSize) {
+ public Object doRprof(String filename, boolean append, double intervalD, boolean memProfiling, boolean gcProfiling, boolean lineProfiling, @SuppressWarnings("unused") int numFiles,
+ @SuppressWarnings("unused") int bufSize) {
RprofState profState = RprofState.get();
if (filename.length() == 0) {
// disable
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ConditionFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ConditionFunctions.java
index 00bae3fd40..b56352f791 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ConditionFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ConditionFunctions.java
@@ -26,10 +26,7 @@ import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.frame.FrameSlot;
import com.oracle.truffle.api.frame.FrameSlotTypeException;
import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
-import com.oracle.truffle.r.nodes.builtin.base.foreign.CallAndExternalFunctions.DotExternal2;
import com.oracle.truffle.r.nodes.function.FunctionDefinitionNode;
import com.oracle.truffle.r.nodes.function.PromiseHelperNode;
import com.oracle.truffle.r.runtime.RError;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/DuplicatedFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/DuplicatedFunctions.java
index 88cf01b06e..79f201063c 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/DuplicatedFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/DuplicatedFunctions.java
@@ -22,7 +22,6 @@ import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.profiles.ConditionProfile;
import com.oracle.truffle.r.nodes.binary.CastTypeNode;
import com.oracle.truffle.r.nodes.binary.CastTypeNodeGen;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.nodes.unary.TypeofNode;
import com.oracle.truffle.r.nodes.unary.TypeofNodeGen;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/GrepFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/GrepFunctions.java
index 2153136a4d..4e0ca4c615 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/GrepFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/GrepFunctions.java
@@ -23,13 +23,11 @@ import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.regex.PatternSyntaxException;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
import com.oracle.truffle.api.CompilerDirectives;
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
import com.oracle.truffle.api.dsl.Fallback;
import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.r.nodes.attributes.SetFixedAttributeNode;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RInternalError;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ListBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ListBuiltin.java
index 4ef832ba33..e7ffa8d42c 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ListBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/ListBuiltin.java
@@ -32,7 +32,6 @@ import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.nodes.ExplodeLoop;
import com.oracle.truffle.api.profiles.ConditionProfile;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
import com.oracle.truffle.r.nodes.function.opt.ShareObjectNode;
import com.oracle.truffle.r.runtime.ArgumentsSignature;
import com.oracle.truffle.r.runtime.RRuntime;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Mapply.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Mapply.java
index 0eaf07b3d5..4fd7a02227 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Mapply.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Mapply.java
@@ -102,9 +102,8 @@ public abstract class Mapply extends RBuiltinNode {
return RDataFactory.createList(result);
}
- @SuppressWarnings("unused")
@Specialization
- protected Object mApply(VirtualFrame frame, RFunction fun, RAbstractListVector dots, RNull moreArgs) {
+ protected Object mApply(VirtualFrame frame, RFunction fun, RAbstractListVector dots, @SuppressWarnings("unused") RNull moreArgs) {
return mApply(frame, fun, dots, RDataFactory.createList());
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Merge.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Merge.java
index 955e3d4b9f..45dd58eeec 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Merge.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Merge.java
@@ -21,7 +21,6 @@ import static com.oracle.truffle.r.runtime.builtins.RBehavior.PURE;
import static com.oracle.truffle.r.runtime.builtins.RBuiltinKind.INTERNAL;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RRuntime;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NGetText.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NGetText.java
index 147a393876..d72cda8937 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NGetText.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NGetText.java
@@ -29,27 +29,22 @@ import static com.oracle.truffle.r.runtime.builtins.RBehavior.COMPLEX;
import static com.oracle.truffle.r.runtime.builtins.RBuiltinKind.INTERNAL;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.builtins.RBuiltin;
-@SuppressWarnings("unused")
@RBuiltin(name = "ngettext", kind = INTERNAL, parameterNames = {"n", "msg1", "msg2", "domain"}, behavior = COMPLEX)
public abstract class NGetText extends RBuiltinNode {
static {
Casts casts = new Casts(NGetText.class);
casts.arg("n").asIntegerVector().findFirst().mustBe(gte0());
-
casts.arg("msg1").defaultError(RError.Message.MUST_BE_STRING, "msg1").mustBe(stringValue()).asStringVector().mustBe(singleElement()).findFirst();
-
casts.arg("msg2").defaultError(RError.Message.MUST_BE_STRING, "msg2").mustBe(stringValue()).asStringVector().mustBe(singleElement()).findFirst();
-
}
@Specialization()
- protected String getText(int n, String msg1, String msg2, Object domain) {
+ protected String getText(int n, String msg1, String msg2, @SuppressWarnings("unused") Object domain) {
return n == 1 ? msg1 : msg2;
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Names.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Names.java
index fa425d7e20..bb8b0830c7 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Names.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Names.java
@@ -32,8 +32,6 @@ import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.profiles.ConditionProfile;
import com.oracle.truffle.r.nodes.attributes.SpecialAttributesFunctions.GetNamesAttributeNode;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
-import com.oracle.truffle.r.nodes.unary.UnaryNotNode;
import com.oracle.truffle.r.runtime.builtins.RBuiltin;
import com.oracle.truffle.r.runtime.data.RNull;
import com.oracle.truffle.r.runtime.data.RStringVector;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NamespaceFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NamespaceFunctions.java
index 919e2805fb..276bb1ad32 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NamespaceFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/NamespaceFunctions.java
@@ -32,7 +32,6 @@ import static com.oracle.truffle.r.runtime.builtins.RBuiltinKind.INTERNAL;
import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
import com.oracle.truffle.api.dsl.Fallback;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RRuntime;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste.java
index edd0e1c736..9b682fe956 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste.java
@@ -39,7 +39,6 @@ import com.oracle.truffle.api.profiles.ConditionProfile;
import com.oracle.truffle.api.profiles.PrimitiveValueProfile;
import com.oracle.truffle.api.profiles.ValueProfile;
import com.oracle.truffle.r.nodes.binary.BoxPrimitiveNode;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.nodes.function.ClassHierarchyNode;
import com.oracle.truffle.r.nodes.function.call.RExplicitBaseEnvCallDispatcher;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste0.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste0.java
index 4b85eb3b4f..c00334447c 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste0.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Paste0.java
@@ -28,7 +28,6 @@ import static com.oracle.truffle.r.runtime.builtins.RBuiltinKind.INTERNAL;
import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.builtins.RBuiltin;
import com.oracle.truffle.r.runtime.data.RList;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Return.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Return.java
index 4acc844bfc..e990562976 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Return.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Return.java
@@ -72,8 +72,6 @@ public abstract class Return extends RBuiltinNode {
return arguments.length == 1 ? new ReturnSpecial(arguments[0]) : null;
}
- private final BranchProfile isPromiseEvalProfile = BranchProfile.create();
-
static {
Casts.noCasts(Return.class);
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SeqFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SeqFunctions.java
index 01d918d117..27ec4be793 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SeqFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SeqFunctions.java
@@ -29,11 +29,8 @@ import com.oracle.truffle.api.frame.VirtualFrame;
import com.oracle.truffle.api.nodes.Node;
import com.oracle.truffle.api.profiles.BranchProfile;
import com.oracle.truffle.api.profiles.ConditionProfile;
-import com.oracle.truffle.r.library.utils.TypeConvert;
-import com.oracle.truffle.r.nodes.access.variables.LocalReadVariableNode;
import com.oracle.truffle.r.nodes.attributes.SpecialAttributesFunctions.GetClassAttributeNode;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
import com.oracle.truffle.r.nodes.builtin.base.SeqFunctions.SeqInt.IsIntegralNumericNode;
import com.oracle.truffle.r.nodes.builtin.base.SeqFunctionsFactory.GetIntegralNumericNodeGen;
import com.oracle.truffle.r.nodes.builtin.base.SeqFunctionsFactory.IsMissingOrNumericNodeGen;
@@ -103,42 +100,40 @@ public final class SeqFunctions {
}
@TypeSystemReference(RTypesFlatLayout.class)
- @SuppressWarnings("unused")
public abstract static class IsNumericNode extends Node {
public abstract boolean execute(Object obj);
@Specialization
- protected boolean isNumericNode(Integer obj) {
+ protected boolean isNumericNode(@SuppressWarnings("unused") Integer obj) {
return true;
}
@Specialization
- protected boolean isNumericNode(Double obj) {
+ protected boolean isNumericNode(@SuppressWarnings("unused") Double obj) {
return true;
}
@Specialization
- protected boolean isNumericNode(RAbstractIntVector obj) {
+ protected boolean isNumericNode(@SuppressWarnings("unused") RAbstractIntVector obj) {
return true;
}
@Specialization
- protected boolean isNumericNode(RAbstractDoubleVector obj) {
+ protected boolean isNumericNode(@SuppressWarnings("unused") RAbstractDoubleVector obj) {
return true;
}
@Fallback
- protected boolean isNumericNode(Object obj) {
+ protected boolean isNumericNode(@SuppressWarnings("unused") Object obj) {
return false;
}
}
@TypeSystemReference(RTypesFlatLayout.class)
- @SuppressWarnings("unused")
public abstract static class IsMissingOrNumericNode extends IsNumericNode {
@Specialization
- protected boolean isMissingOrNumericNode(RMissing obj) {
+ protected boolean isMissingOrNumericNode(@SuppressWarnings("unused") RMissing obj) {
return true;
}
}
@@ -210,15 +205,14 @@ public final class SeqFunctions {
}
@Specialization(guards = {"!hasClass(args, getClassAttributeNode)"})
- @SuppressWarnings("unused")
protected Object seqNoClassAndNumeric(VirtualFrame frame, RArgsValuesAndNames args,
@Cached("createSeqIntForFastPath()") SeqInt seqInt,
@Cached("lookupSeqInt()") RFunction seqIntFunction,
@Cached("createBinaryProfile()") ConditionProfile isNumericProfile,
- @Cached("createGetClassAttributeNode()") GetClassAttributeNode getClassAttributeNode,
+ @Cached("createGetClassAttributeNode()") @SuppressWarnings("unused") GetClassAttributeNode getClassAttributeNode,
@Cached("createIsMissingOrNumericNode()") IsMissingOrNumericNode fromCheck,
@Cached("createIsMissingOrNumericNode()") IsMissingOrNumericNode toCheck,
- @Cached("createIsMissingOrNumericNode()") IsMissingOrNumericNode byCheck) {
+ @Cached("createIsMissingOrNumericNode()") @SuppressWarnings("unused") IsMissingOrNumericNode byCheck) {
Object[] rargs = reorderedArguments(args, seqIntFunction);
if (isNumericProfile.profile(fromCheck.execute(rargs[0]) && toCheck.execute(rargs[1]) && toCheck.execute(rargs[2]))) {
return seqInt.execute(frame, rargs[0], rargs[1], rargs[2], rargs[3], rargs[4]);
@@ -227,9 +221,8 @@ public final class SeqFunctions {
}
}
- @SuppressWarnings("unused")
@Fallback
- protected Object seqFallback(VirtualFrame frame, Object args) {
+ protected Object seqFallback(@SuppressWarnings("unused") Object args) {
return null;
}
@@ -349,8 +342,7 @@ public final class SeqFunctions {
@Specialization(guards = "hasClass(value)")
protected RIntSequence seq(VirtualFrame frame, Object value,
@Cached("createLengthResultCast()") CastNode resultCast,
- @Cached("createLengthDispatcher()") RExplicitBaseEnvCallDispatcher dispatcher,
- @Cached("create()") BranchProfile errorProfile) {
+ @Cached("createLengthDispatcher()") RExplicitBaseEnvCallDispatcher dispatcher) {
int result = (Integer) resultCast.execute(dispatcher.call(frame, value));
return RDataFactory.createIntSequence(1, 1, result);
}
@@ -568,8 +560,8 @@ public final class SeqFunctions {
/**
* The performance of this specialization, we assert, is not important. It captures a
* mixture of coercions from improbable types and error cases. N.B. However, mixing doubles
- * and ints <b<will</b> hit this specialization; is that likely and a concern? If
- * "from ==missing", it defaults to 1.0. "to" cannot be missing as that would overlap with
+ * and ints <b<will</b> hit this specialization; is that likely and a concern? If "from
+ * ==missing", it defaults to 1.0. "to" cannot be missing as that would overlap with
* previous specializations.
*/
@Specialization(guards = {"!isMissing(toObj)"})
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SerializeFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SerializeFunctions.java
index 94ba8ac89e..82f063958e 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SerializeFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SerializeFunctions.java
@@ -35,7 +35,6 @@ import java.io.IOException;
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RError.Message;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SortFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SortFunctions.java
index 14ab57ffcf..7ae1a1ce6e 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SortFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/SortFunctions.java
@@ -36,7 +36,6 @@ import java.util.Collections;
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RRuntime;
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/foreign/CallAndExternalFunctions.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/foreign/CallAndExternalFunctions.java
index 40b188aed7..1eae282329 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/foreign/CallAndExternalFunctions.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/foreign/CallAndExternalFunctions.java
@@ -633,7 +633,7 @@ public class CallAndExternalFunctions {
}
}
- private RExternalBuiltinNode lookupGraphicsBuiltin(String name) {
+ private static RExternalBuiltinNode lookupGraphicsBuiltin(String name) {
switch (name) {
// grDevices
case "cairoProps":
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltin.java
index 0af31a8756..48c2028bde 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "<-", visibility = RVisibility.OFF, kind = PRIMITIVE, parameterNames = {"x", "i"}, behavior = RBehavior.MODIFIES_FRAME)
public abstract class AssignBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x, Object i) {
+ protected Object doIt(@SuppressWarnings("unused") Object x, @SuppressWarnings("unused") Object i) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltinEq.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltinEq.java
index 95885e8a30..26185da3e6 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltinEq.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignBuiltinEq.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "=", visibility = RVisibility.OFF, kind = PRIMITIVE, parameterNames = {"x", "i"}, behavior = RBehavior.MODIFIES_FRAME)
public abstract class AssignBuiltinEq extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x, Object i) {
+ protected Object doIt(@SuppressWarnings("unused") Object x, @SuppressWarnings("unused") Object i) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignOuterBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignOuterBuiltin.java
index 3e77803457..fd990f8ec4 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignOuterBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/AssignOuterBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "<<-", visibility = RVisibility.OFF, kind = PRIMITIVE, parameterNames = {"x", "i"}, behavior = COMPLEX)
public abstract class AssignOuterBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x, Object i) {
+ protected Object doIt(@SuppressWarnings("unused") Object x, @SuppressWarnings("unused") Object i) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BraceBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BraceBuiltin.java
index 8f16de33a5..80ff682034 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BraceBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BraceBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "{", visibility = CUSTOM, kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
public abstract class BraceBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BreakBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BreakBuiltin.java
index 01f7da0777..b4dea21f74 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BreakBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/BreakBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -32,9 +32,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "break", kind = PRIMITIVE, parameterNames = {"x"}, behavior = COMPLEX)
public abstract class BreakBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/ForBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/ForBuiltin.java
index 3f73a57513..562c7be2c0 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/ForBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/ForBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "for", visibility = OFF, kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
public abstract class ForBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/FunctionBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/FunctionBuiltin.java
index 8cff9b6229..b1ebcae60c 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/FunctionBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/FunctionBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -32,9 +32,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "function", kind = PRIMITIVE, parameterNames = {"x"}, behavior = READS_FRAME)
public abstract class FunctionBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/IfBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/IfBuiltin.java
index fa86a26fed..9c6ebc6058 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/IfBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/IfBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "if", visibility = CUSTOM, kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
public abstract class IfBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/NextBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/NextBuiltin.java
index b26ceb6269..d83ea35129 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/NextBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/NextBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -32,9 +32,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "next", kind = PRIMITIVE, parameterNames = {"x"}, behavior = COMPLEX)
public abstract class NextBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/RepeatBuiltin.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/RepeatBuiltin.java
index 457a84b43e..5b612ffdcf 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/RepeatBuiltin.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/infix/RepeatBuiltin.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,9 +33,8 @@ import com.oracle.truffle.r.runtime.builtins.RBuiltin;
@RBuiltin(name = "repeat", visibility = OFF, kind = PRIMITIVE, parameterNames = {"x"}, behavior = PURE)
public abstract class RepeatBuiltin extends RBuiltinNode {
- @SuppressWarnings("unused")
@Specialization
- protected Object doIt(Object x) {
+ protected Object doIt(@SuppressWarnings("unused") Object x) {
throw RInternalError.unimplemented();
}
}
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/fastr/FastRContext.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/fastr/FastRContext.java
index 808039cbf1..2b3370bbb8 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/fastr/FastRContext.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/fastr/FastRContext.java
@@ -60,8 +60,6 @@ import com.oracle.truffle.r.runtime.data.model.RAbstractStringVector;
*/
public class FastRContext {
- private static final String[] EMPTY = new String[0];
-
private static final class CastsHelper {
private static void exprs(Casts casts) {
casts.arg("exprs").asStringVector().mustBe(notEmpty());
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/AccessSlotNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/AccessSlotNode.java
index c35d7aca70..2a5d3799e8 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/AccessSlotNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/AccessSlotNode.java
@@ -125,9 +125,8 @@ public abstract class AccessSlotNode extends RBaseNode {
return (RFunction) RContext.getRRuntimeASTAccess().forcePromise(name, f);
}
- @SuppressWarnings("unused")
@Specialization(guards = {"!slotAccessAllowed(object)", "isDotData(name)"})
- protected Object getSlotNonS4(RAttributable object, String name) {
+ protected Object getSlotNonS4(RAttributable object, @SuppressWarnings("unused") String name) {
// TODO: any way to cache it or use a mechanism similar to overrides?
REnvironment methodsNamespace = REnvironment.getRegisteredNamespace("methods");
RFunction dataPart = getDataPartFunction(methodsNamespace);
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/BaseWriteVariableNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/BaseWriteVariableNode.java
index 52fa750d03..62d0f967d3 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/BaseWriteVariableNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/BaseWriteVariableNode.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -120,18 +120,19 @@ abstract class BaseWriteVariableNode extends WriteVariableNode {
}
}
- @SuppressWarnings("unused")
- protected boolean isLogicalKind(Frame frame, FrameSlot frameSlot) {
+ /*
+ * The frame parameters are needed to keep the guards from being considered static.
+ */
+
+ protected boolean isLogicalKind(@SuppressWarnings("unused") Frame frame, FrameSlot frameSlot) {
return isKind(frameSlot, FrameSlotKind.Boolean);
}
- @SuppressWarnings("unused")
- protected boolean isIntegerKind(Frame frame, FrameSlot frameSlot) {
+ protected boolean isIntegerKind(@SuppressWarnings("unused") Frame frame, FrameSlot frameSlot) {
return isKind(frameSlot, FrameSlotKind.Int);
}
- @SuppressWarnings("unused")
- protected boolean isDoubleKind(Frame frame, FrameSlot frameSlot) {
+ protected boolean isDoubleKind(@SuppressWarnings("unused") Frame frame, FrameSlot frameSlot) {
return isKind(frameSlot, FrameSlotKind.Double);
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCastNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCastNode.java
index 78414fda33..06410a6a10 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCastNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCastNode.java
@@ -52,7 +52,6 @@ import com.oracle.truffle.r.runtime.data.model.RAbstractVector;
import com.oracle.truffle.r.runtime.env.REnvironment;
import com.oracle.truffle.r.runtime.ops.na.NACheck;
-@SuppressWarnings("unused")
abstract class PositionCastNode extends Node {
private final ElementAccessMode mode;
@@ -143,7 +142,7 @@ abstract class PositionCastNode extends Node {
}
@Specialization
- protected RMissing doMissing(RMissing position) {
+ protected RMissing doMissing(@SuppressWarnings("unused") RMissing position) {
if (mode.isSubscript()) {
if (replace) {
throw RError.error(this, RError.Message.MISSING_SUBSCRIPT);
@@ -156,12 +155,12 @@ abstract class PositionCastNode extends Node {
}
@Specialization
- protected RMissing doEmpty(REmpty position) {
+ protected RMissing doEmpty(@SuppressWarnings("unused") REmpty position) {
return doMissing(null);
}
@Specialization
- protected RAbstractVector doNull(RNull position) {
+ protected RAbstractVector doNull(@SuppressWarnings("unused") RNull position) {
// NULL expands to integer(0).
return RDataFactory.createEmptyIntVector();
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubscriptNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubscriptNode.java
index 597de75756..2514a0825a 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubscriptNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubscriptNode.java
@@ -52,9 +52,8 @@ abstract class PositionCheckSubscriptNode extends PositionCheckNode {
this.recursive = recursive;
}
- @SuppressWarnings("unused")
@Specialization
- protected Object doMissing(PositionProfile statistics, int dimSize, RMissing position, int positionLength) {
+ protected Object doMissing(PositionProfile statistics, int dimSize, RMissing position, @SuppressWarnings("unused") int positionLength) {
statistics.selectedPositionsCount = dimSize;
return position;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubsetNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubsetNode.java
index caa31c70be..e7c74e62eb 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubsetNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/PositionCheckSubsetNode.java
@@ -56,9 +56,8 @@ abstract class PositionCheckSubsetNode extends PositionCheckNode {
super(mode, containerType, positionValue, dimensionIndex, numDimensions, exact, assignment);
}
- @SuppressWarnings("unused")
@Specialization
- protected Object doMissing(PositionProfile statistics, int dimSize, RMissing position, int positionLength) {
+ protected Object doMissing(PositionProfile statistics, int dimSize, RMissing position, @SuppressWarnings("unused") int positionLength) {
statistics.selectedPositionsCount = dimSize;
return position;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveExtractSubscriptNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveExtractSubscriptNode.java
index e05312f7a7..6448ae8739 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveExtractSubscriptNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveExtractSubscriptNode.java
@@ -54,8 +54,8 @@ abstract class RecursiveExtractSubscriptNode extends RecursiveSubscriptNode {
protected abstract Object execute(VirtualFrame frame, Object vector, Object[] positions, Object firstPosition, int positionLength, Object exact, Object dropDimensions);
@Specialization(guards = "positionLength <= 1")
- @SuppressWarnings("unused")
- protected Object doDefault(VirtualFrame frame, Object vector, Object[] positions, Object firstPosition, int positionLength, Object exact, Object dropDimensions) {
+ protected Object doDefault(VirtualFrame frame, Object vector, Object[] positions, Object firstPosition, @SuppressWarnings({"unused", "unused"}) int positionLength, Object exact,
+ Object dropDimensions) {
try {
return subscriptExtract.apply(frame, vector, positions, exact, dropDimensions);
} catch (RecursiveIndexNotFoundError e) {
@@ -65,8 +65,8 @@ abstract class RecursiveExtractSubscriptNode extends RecursiveSubscriptNode {
}
@Specialization(replaces = "doDefault")
- @SuppressWarnings("unused")
- protected Object doRecursive(VirtualFrame frame, Object vector, Object[] positions, Object originalFirstPosition, int positionLength, Object exact, Object dropDimensions,
+ protected Object doRecursive(VirtualFrame frame, Object vector, @SuppressWarnings("unused") Object[] positions, Object originalFirstPosition, int positionLength, Object exact,
+ Object dropDimensions,
@Cached("createPositionCast()") PositionCastNode positionCast) {
Object firstPosition = positionCast.execute(originalFirstPosition);
Object currentVector = vector;
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveReplaceSubscriptNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveReplaceSubscriptNode.java
index ca10ed8071..f24cc63744 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveReplaceSubscriptNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/RecursiveReplaceSubscriptNode.java
@@ -55,8 +55,7 @@ abstract class RecursiveReplaceSubscriptNode extends RecursiveSubscriptNode {
protected abstract Object execute(VirtualFrame frame, Object vector, Object[] positions, Object firstPosition, int positionLength, Object value);
@Specialization(guards = "positionLength <= 1")
- @SuppressWarnings("unused")
- protected Object doDefault(VirtualFrame frame, Object vector, Object[] positions, Object firstPosition, int positionLength, Object value) {
+ protected Object doDefault(VirtualFrame frame, Object vector, Object[] positions, @SuppressWarnings("unused") Object firstPosition, @SuppressWarnings("unused") int positionLength, Object value) {
return subscriptReplace.apply(frame, vector, positions, value);
}
@@ -83,8 +82,7 @@ abstract class RecursiveReplaceSubscriptNode extends RecursiveSubscriptNode {
* </code>
*/
@Specialization(replaces = "doDefault")
- @SuppressWarnings("unused")
- protected Object doRecursive(VirtualFrame frame, Object vector, Object[] positions, Object originalFirstPosition, int positionLength, Object value,
+ protected Object doRecursive(VirtualFrame frame, Object vector, @SuppressWarnings("unused") Object[] positions, Object originalFirstPosition, int positionLength, Object value,
@Cached("createPositionCast()") PositionCastNode positionCast) {
Object firstPosition = positionCast.execute(originalFirstPosition);
Object[] positionStack = new Object[positionLength];
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/WriteIndexedVectorNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/WriteIndexedVectorNode.java
index 640c0d1326..8f9270d9cc 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/WriteIndexedVectorNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/vector/WriteIndexedVectorNode.java
@@ -190,10 +190,9 @@ abstract class WriteIndexedVectorNode extends Node {
Object[] positions, Object position, int positionOffset, int positionLength,
RTypedValue right, Object rightStore, int valueBase, int valueLength, boolean parentNA);
- @SuppressWarnings("unused")
@Specialization
protected int doMissing(RAbstractVector left, Object leftStore, int leftBase, int leftLength, Object targetDimensions, int targetDimension,
- Object[] positions, RMissing position, int positionOffset, int positionLength,
+ Object[] positions, @SuppressWarnings("unused") RMissing position, int positionOffset, @SuppressWarnings("unused") int positionLength,
RAbstractContainer right, Object rightStore, int rightBase, int rightLength, boolean parentNA,
@Cached("createCountingProfile()") LoopConditionProfile profile) {
int rightIndex = rightBase;
@@ -316,7 +315,6 @@ abstract class WriteIndexedVectorNode extends Node {
return rightIndex;
}
- @SuppressWarnings("all")
private int applyInner(//
RAbstractVector left, Object leftStore, int leftBase, int leftLength, Object targetDimensions,
Object[] positions, int positionOffset, int positionValue,
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/CopyOfRegAttributesNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/CopyOfRegAttributesNode.java
index e60b782348..7118f008d8 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/CopyOfRegAttributesNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/CopyOfRegAttributesNode.java
@@ -58,9 +58,8 @@ public abstract class CopyOfRegAttributesNode extends RBaseNode {
return CopyOfRegAttributesNodeGen.create();
}
- @SuppressWarnings("unused")
@Specialization(guards = "source.getAttributes() == null")
- protected void copyNoAttributes(RAbstractVector source, RVector<?> target) {
+ protected void copyNoAttributes(@SuppressWarnings("unused") RAbstractVector source, @SuppressWarnings("unused") RVector<?> target) {
// nothing to do
}
@@ -69,9 +68,8 @@ public abstract class CopyOfRegAttributesNode extends RBaseNode {
return attributes == null || attributes.isEmpty();
}
- @SuppressWarnings("unused")
@Specialization(guards = "emptyAttributes(source)", replaces = "copyNoAttributes")
- protected void copyEmptyAttributes(RAbstractVector source, RVector<?> target) {
+ protected void copyEmptyAttributes(@SuppressWarnings("unused") RAbstractVector source, @SuppressWarnings("unused") RVector<?> target) {
// nothing to do
}
@@ -80,9 +78,8 @@ public abstract class CopyOfRegAttributesNode extends RBaseNode {
return attributes != null && sizeOneProfile.profile(attributes.size() == 1) && dimAttrGetter.execute(attributes) != null;
}
- @SuppressWarnings("unused")
@Specialization(guards = "onlyDimAttribute(source)")
- protected void copyDimOnly(RAbstractVector source, RVector<?> target) {
+ protected void copyDimOnly(@SuppressWarnings("unused") RAbstractVector source, @SuppressWarnings("unused") RVector<?> target) {
// nothing to do
}
@@ -91,9 +88,8 @@ public abstract class CopyOfRegAttributesNode extends RBaseNode {
return attributes != null && sizeOneProfile.profile(attributes.size() == 1) && namesAttrGetter.execute(attributes) != null;
}
- @SuppressWarnings("unused")
@Specialization(guards = "onlyNamesAttribute(source)")
- protected void copyNamesOnly(RAbstractVector source, RVector<?> target) {
+ protected void copyNamesOnly(@SuppressWarnings("unused") RAbstractVector source, @SuppressWarnings("unused") RVector<?> target) {
// nothing to do
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/HasFixedAttributeNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/HasFixedAttributeNode.java
index 0de42b9a39..24f02dcac6 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/HasFixedAttributeNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/HasFixedAttributeNode.java
@@ -67,9 +67,8 @@ public abstract class HasFixedAttributeNode extends FixedAttributeAccessNode {
@Specialization(limit = "3", //
guards = {"shapeCheck(shape, attrs)"}, //
assumptions = {"shape.getValidAssumption()"})
- @SuppressWarnings("unused")
- protected boolean hasAttrCached(DynamicObject attrs,
- @Cached("lookupShape(attrs)") Shape shape,
+ protected boolean hasAttrCached(@SuppressWarnings("unused") DynamicObject attrs,
+ @Cached("lookupShape(attrs)") @SuppressWarnings("unused") Shape shape,
@Cached("lookupLocation(shape, name)") Location location) {
return location != null;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/SetAttributeNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/SetAttributeNode.java
index ba5d803b0c..dd75f36d56 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/SetAttributeNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/SetAttributeNode.java
@@ -72,9 +72,8 @@ public abstract class SetAttributeNode extends AttributeAccessNode {
assumptions = {
"shape.getValidAssumption()"
})
- @SuppressWarnings("unused")
- protected static void setExistingAttrCached(DynamicObject attrs, String name, Object value,
- @Cached("name") String cachedName,
+ protected static void setExistingAttrCached(DynamicObject attrs, @SuppressWarnings("unused") String name, Object value,
+ @Cached("name") @SuppressWarnings("unused") String cachedName,
@Cached("lookupShape(attrs)") Shape shape,
@Cached("lookupLocation(shape, name, value)") Location location) {
try {
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/TypeFromModeNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/TypeFromModeNode.java
index f44b724a1d..6e4fbbc901 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/TypeFromModeNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/TypeFromModeNode.java
@@ -40,10 +40,9 @@ public abstract class TypeFromModeNode extends Node {
public abstract RType execute(Object mode);
- @SuppressWarnings("unused")
@Specialization(limit = "CACHE_LIMIT", guards = "mode == cachedMode")
- protected RType getTypeCAched(String mode,
- @Cached("mode") String cachedMode,
+ protected RType getTypeCAched(@SuppressWarnings("unused") String mode,
+ @Cached("mode") @SuppressWarnings("unused") String cachedMode,
@Cached("fromMode(mode)") RType type) {
return type;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/ValueForwardingNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/ValueForwardingNode.java
index 623afa39a4..f3baa1bb85 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/ValueForwardingNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/ValueForwardingNode.java
@@ -35,7 +35,7 @@ import com.oracle.truffle.r.runtime.data.RNull;
public abstract class ValueForwardingNode extends CastNode {
- @SuppressWarnings("unused") protected final ForwardingAnalysisResult forwardingResult;
+ protected final ForwardingAnalysisResult forwardingResult;
private final Supplier<CastNode> pipelineFactory;
protected ValueForwardingNode(ForwardingAnalysisResult forwardingResult, Supplier<CastNode> pipelineFactory) {
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/fluent/PipelineBuilder.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/fluent/PipelineBuilder.java
index b660585cb2..692850cdc8 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/fluent/PipelineBuilder.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/builtin/casts/fluent/PipelineBuilder.java
@@ -25,7 +25,6 @@ package com.oracle.truffle.r.nodes.builtin.casts.fluent;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicReference;
-import com.oracle.truffle.r.nodes.builtin.CastBuilder;
import com.oracle.truffle.r.nodes.builtin.casts.Filter;
import com.oracle.truffle.r.nodes.builtin.casts.Mapper;
import com.oracle.truffle.r.nodes.builtin.casts.MessageData;
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/RLengthNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/RLengthNode.java
index b16e8e51ce..a7a57f523a 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/RLengthNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/RLengthNode.java
@@ -59,38 +59,32 @@ public abstract class RLengthNode extends RNode {
}
@Specialization
- @SuppressWarnings("unused")
- protected int doNull(RNull operand) {
+ protected int doNull(@SuppressWarnings("unused") RNull operand) {
return 0;
}
@Specialization
- @SuppressWarnings("unused")
- protected int doLogical(byte operand) {
+ protected int doLogical(@SuppressWarnings("unused") byte operand) {
return 1;
}
@Specialization
- @SuppressWarnings("unused")
- protected int doInteger(int operand) {
+ protected int doInteger(@SuppressWarnings("unused") int operand) {
return 1;
}
@Specialization
- @SuppressWarnings("unused")
- protected int doDouble(double operand) {
+ protected int doDouble(@SuppressWarnings("unused") double operand) {
return 1;
}
@Specialization
- @SuppressWarnings("unused")
- protected int doString(String operand) {
+ protected int doString(@SuppressWarnings("unused") String operand) {
return 1;
}
@Specialization
- @SuppressWarnings("unused")
- protected int doSymbol(RSymbol operand) {
+ protected int doSymbol(@SuppressWarnings("unused") RSymbol operand) {
return 1;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/call/RExplicitBaseEnvCallDispatcher.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/call/RExplicitBaseEnvCallDispatcher.java
index 3987f7dfb1..61d2917f3e 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/call/RExplicitBaseEnvCallDispatcher.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/call/RExplicitBaseEnvCallDispatcher.java
@@ -26,7 +26,6 @@ import com.oracle.truffle.api.dsl.Cached;
import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.frame.VirtualFrame;
import com.oracle.truffle.api.nodes.Node;
-import com.oracle.truffle.api.profiles.BranchProfile;
import com.oracle.truffle.r.nodes.access.variables.LocalReadVariableNode;
import com.oracle.truffle.r.nodes.function.GetBaseEnvFrameNode;
import com.oracle.truffle.r.runtime.ArgumentsSignature;
@@ -38,7 +37,7 @@ import com.oracle.truffle.r.runtime.data.RFunction;
* assumption that a function in base environment is not going to change and can be cached.
*/
public abstract class RExplicitBaseEnvCallDispatcher extends Node {
- private final BranchProfile errorProfile = BranchProfile.create();
+
@Child private LocalReadVariableNode readFunc;
@Child RExplicitCallNode callNode = RExplicitCallNode.create();
@Child GetBaseEnvFrameNode getBaseEnvFrameNode = GetBaseEnvFrameNode.create();
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CollectArgumentsNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CollectArgumentsNode.java
index 8cae02ab03..0be21e8e3d 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CollectArgumentsNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CollectArgumentsNode.java
@@ -61,11 +61,10 @@ public abstract class CollectArgumentsNode extends RBaseNode {
return reads;
}
- @SuppressWarnings("unused")
@ExplodeLoop
@Specialization(limit = "CACHE_LIMIT", guards = {"cachedSignature == signature"})
- protected Object[] combineCached(VirtualFrame frame, ArgumentsSignature signature,
- @Cached("signature") ArgumentsSignature cachedSignature,
+ protected Object[] combineCached(VirtualFrame frame, @SuppressWarnings("unused") ArgumentsSignature signature,
+ @Cached("signature") @SuppressWarnings("unused") ArgumentsSignature cachedSignature,
@Cached("createArgs(signature, frame)") Node[] reads) {
Object[] result = new Object[reads.length];
for (int i = 0; i < reads.length; i++) {
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CombineSignaturesNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CombineSignaturesNode.java
index b360a6e5aa..35e5972874 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CombineSignaturesNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/function/signature/CombineSignaturesNode.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -64,12 +64,10 @@ public abstract class CombineSignaturesNode extends RBaseNode {
return new RArgsValuesAndNames(leftValues, left);
}
- @SuppressWarnings("unused")
- @Specialization(limit = "CACHE_LIMIT", guards = {"left == leftCached", "right == rightCached", "leftValues == leftValuesCached", "!right.isEmpty()", "!left.isEmpty()"})
- protected RArgsValuesAndNames combineCached(ArgumentsSignature left, Object[] leftValues, ArgumentsSignature right, Object[] rightValues,
- @Cached("left") ArgumentsSignature leftCached,
- @Cached("leftValues") Object[] leftValuesCached,
- @Cached("right") ArgumentsSignature rightCached,
+ @Specialization(limit = "CACHE_LIMIT", guards = {"left == leftCached", "right == rightCached", "!right.isEmpty()", "!left.isEmpty()"})
+ protected RArgsValuesAndNames combineCached(ArgumentsSignature left, Object[] leftValues, @SuppressWarnings("unused") ArgumentsSignature right, Object[] rightValues,
+ @Cached("left") @SuppressWarnings("unused") ArgumentsSignature leftCached,
+ @Cached("right") @SuppressWarnings("unused") ArgumentsSignature rightCached,
@Cached("combine(left, leftValues, right)") CombineResult resultCached,
@Cached("createBinaryProfile()") ConditionProfile shufflingProfile,
@Cached("createBinaryProfile()") ConditionProfile noVarArgsProfile) {
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/TypeofNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/TypeofNode.java
index 580995b0cb..358b1b3ce4 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/TypeofNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/TypeofNode.java
@@ -29,7 +29,6 @@ import com.oracle.truffle.r.runtime.RType;
import com.oracle.truffle.r.runtime.data.RMissing;
import com.oracle.truffle.r.runtime.data.RTypedValue;
-@SuppressWarnings("unused")
public abstract class TypeofNode extends UnaryNode {
protected static final int NUMBER_OF_CACHED_CLASSES = 5;
@@ -38,27 +37,27 @@ public abstract class TypeofNode extends UnaryNode {
public abstract RType execute(Object x);
@Specialization
- protected static RType doLogical(byte x) {
+ protected static RType doLogical(@SuppressWarnings("unused") byte x) {
return RType.Logical;
}
@Specialization
- protected static RType doInt(int s) {
+ protected static RType doInt(@SuppressWarnings("unused") int s) {
return RType.Integer;
}
@Specialization
- protected static RType doDouble(double x) {
+ protected static RType doDouble(@SuppressWarnings("unused") double x) {
return RType.Double;
}
@Specialization
- protected static RType doString(String x) {
+ protected static RType doString(@SuppressWarnings("unused") String x) {
return RType.Character;
}
@Specialization
- protected static RType doMissing(RMissing x) {
+ protected static RType doMissing(@SuppressWarnings("unused") RMissing x) {
return RType.Missing;
}
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryArithmeticReduceNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryArithmeticReduceNode.java
index 881043c134..2d3092d235 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryArithmeticReduceNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryArithmeticReduceNode.java
@@ -116,7 +116,7 @@ public abstract class UnaryArithmeticReduceNode extends RBaseNode {
}
@Specialization
- protected int doInt(int operand, boolean naRm, boolean finite) {
+ protected int doInt(int operand, boolean naRm, @SuppressWarnings("unused") boolean finite) {
na.enable(operand);
if (naRmProfile.profile(naRm)) {
if (na.check(operand)) {
diff --git a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryNotNode.java b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryNotNode.java
index 88d39a7818..1d28787a26 100644
--- a/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryNotNode.java
+++ b/com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/unary/UnaryNotNode.java
@@ -31,7 +31,6 @@ import com.oracle.truffle.api.dsl.Fallback;
import com.oracle.truffle.api.dsl.Specialization;
import com.oracle.truffle.api.profiles.ConditionProfile;
import com.oracle.truffle.r.nodes.builtin.RBuiltinNode;
-import com.oracle.truffle.r.nodes.builtin.NodeWithArgumentCasts.Casts;
import com.oracle.truffle.r.runtime.RError;
import com.oracle.truffle.r.runtime.RRuntime;
import com.oracle.truffle.r.runtime.builtins.RBuiltin;
diff --git a/com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RSrcref.java b/com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RSrcref.java
index c2b9e89aa7..d2a27b6377 100644
--- a/com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RSrcref.java
+++ b/com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RSrcref.java
@@ -28,7 +28,6 @@ import com.oracle.truffle.r.runtime.data.RStringVector;
import com.oracle.truffle.r.runtime.env.REnvironment;
import com.oracle.truffle.r.runtime.env.REnvironment.PutException;
import com.oracle.truffle.r.runtime.ffi.BaseRFFI;
-import com.oracle.truffle.r.runtime.ffi.RFFIFactory;
import com.oracle.truffle.r.runtime.nodes.RSyntaxNode;
/**
diff --git a/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_parse.java b/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_parse.java
index fa4d7c9cce..bee6607ab3 100644
--- a/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_parse.java
+++ b/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_parse.java
@@ -13,7 +13,6 @@ package com.oracle.truffle.r.test.builtins;
import org.junit.Test;
import com.oracle.truffle.r.test.TestBase;
-import java.io.IOException;
// Checkstyle: stop line length check
@@ -60,8 +59,7 @@ public class TestBuiltin_parse extends TestBase {
}
@Test
- public void testSrcfile() throws IOException {
+ public void testSrcfile() {
assertEval("parse(text='', srcfile=srcfile(system.file('testfile')))");
}
-
}
--
GitLab