From 7e78179b7961b65c73ddde58e11003aed4c7b087 Mon Sep 17 00:00:00 2001
From: Lukas Stadler <lukas.stadler@oracle.com>
Date: Wed, 21 Dec 2016 15:13:17 +0100
Subject: [PATCH] minor cleanups
---
.../src/com/oracle/truffle/r/nodes/builtin/base/CRC64.java | 4 ++--
.../src/com/oracle/truffle/r/test/builtins/TestTestBase.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/CRC64.java b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/CRC64.java
index c4a29770e6..c492da931b 100644
--- a/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/CRC64.java
+++ b/com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/CRC64.java
@@ -52,13 +52,13 @@ public abstract class CRC64 extends RBuiltinNode {
bytes = crc64(bytes);
long l = 0;
for (int i = 0; i < bytes.length; i++) {
- l += ((long) bytes[i] & 0xffL) << (8 * i);
+ l += (bytes[i] & 0xffL) << (8 * i);
}
return RDataFactory.createStringVector(Long.toHexString(l));
}
@TruffleBoundary
- private byte[] crc64(byte[] bytes) {
+ private static byte[] crc64(byte[] bytes) {
org.tukaani.xz.check.CRC64 crc = new org.tukaani.xz.check.CRC64();
crc.update(bytes);
return crc.finish();
diff --git a/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestTestBase.java b/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestTestBase.java
index 235264d822..be53842774 100644
--- a/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestTestBase.java
+++ b/com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestTestBase.java
@@ -55,7 +55,7 @@ public class TestTestBase extends TestBase {
getCode("cat('Warning message: In .Internal(foo(42)): IgnoreWarningContext diff message')", "cat('Warning message in foo(42): IgnoreWarningContext should fail')"));
}
- private String getCode(String fastr, String gnur) {
+ private static String getCode(String fastr, String gnur) {
return "if (exists('.fastr.identity')) { " + fastr + " } else { " + gnur + " }";
}
}
--
GitLab