Skip to content

Remove score rouding in Submissions tab

Placeholder Adrien Pavão requested to merge no-rounding into develop

The score found in the "My Submissions" tab is not coherent with the leaderboard score. This is likely due to an imprecision in the rounding using javascript.

This PR simply removes the rounding, so we have a long float in "My Submissions" table. Maybe instead we should look at how the leaderboard score is retrieved.

We need a bundle and submissions that reproduce the difference between the leaderboard score and "My submissions" score to test this.


Maybe parseFloat is also imprecise


Other ways of rounding in javascript are described here: https://sanori.github.io/2019/04/JavaScript-Pitfalls-Tips-toFixed/

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

Merge request reports

Loading