Skip to content

Number of remaining submissions per person and per day

Placeholder Ihsan Ullah requested to merge num_sub_used into develop

@ mention of reviewers`

@Didayolo`

A brief description of the purpose of the changes contained in this PR.

When you create a competition from the UI, the default value used for has_max_submissions is False. When this is False we never check the submission limit per day or per person. Now, the Phase model is updated and the default value is set to True.

Note 1:

this will effect new competitions only. In order to fix current competitions, has_max_submissions has to be set to True in the db. Something like this

UPDATE Phase_Table SET has_max_submissions = true;

Note 2:

If user is bot and robot submissions are allowed, then we do not check for the limit in that case. See this line of code: https://github.com/codalab/codabench/blob/e38b1e343e885e993c201613e7b227f3927dc083/src/apps/competitions/models.py#L311

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

Merge request reports