Skip to content

Caddy

Placeholder Obada Haddad-Soussac requested to merge caddy into develop

@ mention of reviewers`

@Didayolo @ihsaan-ullah`

A brief description of the purpose of the changes contained in this PR.

This should fix the problem of persistent certificates on caddy:

  • I changed the caddy image to the official one, upgrading it to version 2.7.6 (the one we were using was an unofficial 1.0.3)
  • I updated the syntax of the Caddyfile to support the changes caddy v2 brings
  • Changed the volumes in the docker-compose.yml for the container to use the recommended ones from caddy's Docker Hub
    • Added ./caddy_data:/data which is used by the image to store important information, certificates included.
    • Added ./caddy_config:/config which is used by the image to store some configuration (I'm not sure if it's really needed in our case)
    • Renamed ./Caddyfile:/etc/Caddyfile to ./Caddyfile:/etc/caddy/Caddyfile (new official location for the Caddyfile)
    • Removed ./certs/caddy:/etc/caddycerts which is not present on the official Docker Hub

Issues this PR resolves

#1349 (closed)

A checklist for hand testing

  • Make sure the Caddyfile changes are enough for every part of the website

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

Merge request reports

Loading