Delete resources on failed competition creation
@ mention of reviewers`
@ckcollab
@Logan-Ruf`
A brief description of the purpose of the changes contained in this PR.
This PR adds cleanup of uploaded competition files when the competition unpacker fails.
Issues this PR resolves
Known issues to be addressed in a separate PR
It's possible to upload a competition directly though the api and the cleanup code won't be called. Maybe should address this in the future. This cleans up the dataset without a subsequent request to get the creation status of the competition now.
A checklist for hand testing
-
Upload a failing competition -
Check that the CompetitionCreationTaskStatus
andData
objects and the competition zip have all been deleted
Checklist
-
Code review by me -
Hand tested by me -
I'm proud of my work -
Code review by reviewer -
Hand tested by reviewer -
Ready to merge