Skip to content

text/html content header for detailed_results.html or *.html files

Placeholder Benjamin Bearce requested to merge detailed_results_not_showing into develop

Content Type Update For Detailed Results HTML Files

@ mention of reviewers`

@Didayolo`

A brief description of the purpose of the changes contained in this PR.

Detailed results html files weren't showing in the VISUALIZATION tab when viewing a submission's results.

The content-type of the html file was being saved as "binary/octet-stream". This link will retrieve the detailed_results.html if you search it in the URL search in a browser as this content-type allows for that. The link to the minio location is embedded in the html in an iframe on the VISUALIZATION tab however and this causes the html to not be rendered.

A checklist for hand testing

  • Upload IRIS (warning the old IRIS has a yaml bug in the scoring program requiring you to add yaml.Loader as an argument) or Hello World or any challenge that has the scoring program generate *.html detailed results files.
  • Make submission
  • Check the VISUALIZATION tab for results

image

Any relevant files for testing

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

Merge request reports