Skip to content

Issue 733 - Manual comp creation now will save leaderboard

Placeholder Benjamin Bearce requested to merge manual_ui_challenge_creation_issue_733 into develop

@ mention of reviewers`

@Didayolo @Tthomas63`

A brief description of the purpose of the changes contained in this PR.

Upon manual UI challenge creation, the leaderboard isn't saved.

Issues this PR resolves

733 (https://github.com/codalab/codabench/issues/733)

Known issues to be addressed in a separate PR

N/A

A checklist for hand testing

  • Make a challenge using the form in the UI and don't forget to create a leaderboard.
  • Next once competition is created, go to edit and make sure the leaderboard you created still exists.
  • Also go to results tab and make sure you can see the leaderboard.

Any relevant files for testing

N/A

Misc. comments

I'm worried that this fix and the underlying code I copied or updating a challenge is not what the original creators wanted. See this comment above the code I copied: https://github.com/codalab/codabench/blob/73cacee18a72ffa129938098b9b341d6b807759a/src/apps/api/views/competitions.py#L148.

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

Merge request reports