Skip to content

new feature: email confirmation

Placeholder Benjamin Bearce requested to merge email_confirmation_738 into develop

@ mention of reviewers`

@Tristan`` @Didayolo`

A brief description of the purpose of the changes contained in this PR.

There was no email confirmation and we don't want spam accounts to build up quickly.

Issues this PR resolves

https://github.com/codalab/codabench/issues/738

Known issues to be addressed in a separate PR

...

A checklist for hand testing

  • Sign up and check to see that a green message shows up to let you know you need to check your email.
  • Check the confirmation link shows up and click it.
  • Verify that you are brought to the login page and see a message telling you that you are all signed up and to log in.
  • Check that you can log in.

Test error case:

  • Sign up and check to see that a green message shows up to let you know you need to check your email.
  • Check the confirmation link shows up and copy most but not all of the link.
  • When navigating to this link, you should be brought to the sign-up page with red message indicating the link was corrupt. This should have deleted your user in the process and you should retry signing up.
  • You should be able to correctly sign up, click activation link, and login after this.

Any relevant files for testing

...

Misc. comments

I'm a little worried I unnecessarily added django "messages" (https://docs.djangoproject.com/en/4.1/ref/contrib/messages/) to the base.html template when I could up setup messages based on API calls (already how things are setup). The problem was I couldn't find how to catch the return response from the signup API call, which is where most messaging functionality happens. We didn't have messages setup as the code was using a javascript package called "toastr" to flash messages. I was able to use django messages (which is nice as we can use them now in the future) and wrap them in toastr so we can get the cool flashes that pop up and everything looks consistent. This is my only worry as far as implementing this correctly.

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • Ready to merge

Merge request reports