[GR-9978] Fix bug in La_chol (incorrect pivot attribute in return).

PullRequest: fastr/1652

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/LaFunctions.java

@@ -593,7 +593,7 @@ public class LaFunctions {
             }
 
             RDoubleVector result = (RDoubleVector) copyAttributesNode.execute(RDataFactory.createDoubleVector(aData, RDataFactory.INCOMPLETE_VECTOR), aIn);
-            setPivotAttrNode.execute(result, RRuntime.asLogical(piv));
+            setPivotAttrNode.execute(result, RDataFactory.createIntVector(ipiv, false));
             setRankAttrNode.execute(result, rank[0]);
             RList dn = getDimNamesNode.getDimNames(aIn);
             if (dn != null && dn.getDataAt(0) != null) {

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/ExpectedTestOutput.test

@@ -15467,6 +15467,16 @@ Error in chartr(c("abq"), "cd", c("agbc", "efb")) :
 Error in chartr(c(3, 2), c("q", "c"), c("abc", "efb")) :
   invalid 'old' argument
+##com.oracle.truffle.r.test.builtins.TestBuiltin_chol.testChol#
+#chol(matrix(c(4,2,2,3), ncol=2), pivot=TRUE)
+     [,1]     [,2]
+[1,]    2 1.000000
+[2,]    0 1.414214
+attr(,"pivot")
+[1] 1 2
+attr(,"rank")
+[1] 2
+
 ##com.oracle.truffle.r.test.builtins.TestBuiltin_chol.testChol#
 #{ chol(1) }
      [,1]

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/builtins/TestBuiltin_chol.java

@@ -44,5 +44,6 @@ public class TestBuiltin_chol extends TestBase {
         // the leading minor of order 2 is not positive definite
         // FastR output: Error in chol.default(m) : error code 2 from Lapack routine 'dpotrf'
         assertEval(Output.IgnoreErrorMessage, "{ m <- matrix(c(5,-5,-5,3),2,2) ; chol(m) }");
+        assertEval("chol(matrix(c(4,2,2,3), ncol=2), pivot=TRUE)");
     }
 }