Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Q
QueryR
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Julien Lopez
QueryR
Commits
9f726e00
Commit
9f726e00
authored
8 years ago
by
Lukas Stadler
Browse files
Options
Downloads
Patches
Plain Diff
avoid REGULAR write to current frame for super assignments
parent
40e38eb5
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/ReplacementNode.java
+4
-6
4 additions, 6 deletions
...c/com/oracle/truffle/r/nodes/control/ReplacementNode.java
with
4 additions
and
6 deletions
com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/ReplacementNode.java
+
4
−
6
View file @
9f726e00
...
...
@@ -137,11 +137,11 @@ abstract class ReplacementNode extends OperatorNode {
if
(
i
<
calls
.
size
()
-
1
)
{
instructions
.
add
(
WriteVariableNode
.
createAnonymous
(
"*tmpr*"
+
(
tempNamesStartIndex
+
i
),
update
,
WriteVariableNode
.
Mode
.
INVISIBLE
));
}
else
{
instructions
.
add
(
WriteVariableNode
.
createAnonymous
(
getT
arget
TmpName
(
tempNamesStartIndex
)
,
update
,
WriteVariableNode
.
Mode
.
REGULAR
));
instructions
.
add
(
WriteVariableNode
.
createAnonymous
(
t
arget
VarName
,
update
,
WriteVariableNode
.
Mode
.
REGULAR
,
isSuper
));
}
}
return
new
GenericReplacementNode
(
instructions
,
source
,
operator
,
target
,
lhs
,
rhs
,
targetVarName
,
isSuper
,
tempNamesStartIndex
);
return
new
GenericReplacementNode
(
instructions
,
source
,
operator
,
target
,
lhs
,
rhs
,
tempNamesStartIndex
);
}
/**
...
...
@@ -277,15 +277,13 @@ abstract class ReplacementNode extends OperatorNode {
@Children
private
final
RNode
[]
updates
;
@Child
private
SetVisibilityNode
visibility
=
SetVisibilityNode
.
create
();
GenericReplacementNode
(
List
<
RNode
>
updates
,
SourceSection
source
,
RSyntaxLookup
operator
,
RNode
target
,
RSyntaxElement
lhs
,
RNode
rhs
,
String
targetVarName
,
boolean
isSuper
,
int
tempNamesStartIndex
)
{
GenericReplacementNode
(
List
<
RNode
>
updates
,
SourceSection
source
,
RSyntaxLookup
operator
,
RNode
target
,
RSyntaxElement
lhs
,
RNode
rhs
,
int
tempNamesStartIndex
)
{
super
(
source
,
operator
,
lhs
);
this
.
target
=
target
;
this
.
rhs
=
rhs
;
this
.
updates
=
updates
.
toArray
(
new
RNode
[
updates
.
size
()]);
this
.
targetTmpWrite
=
WriteVariableNode
.
createAnonymous
(
getTargetTmpName
(
tempNamesStartIndex
),
null
,
WriteVariableNode
.
Mode
.
INVISIBLE
);
this
.
targetTmpRemove
=
RemoveAndAnswerNode
.
create
(
getTargetTmpName
(
tempNamesStartIndex
));
this
.
targetWrite
=
WriteVariableNode
.
createAnonymous
(
targetVarName
,
null
,
WriteVariableNode
.
Mode
.
INVISIBLE
,
isSuper
);
this
.
storeRhs
=
WriteVariableNode
.
createAnonymous
(
"*rhs*"
+
tempNamesStartIndex
,
null
,
WriteVariableNode
.
Mode
.
INVISIBLE
);
this
.
removeRhs
=
RemoveAndAnswerNode
.
create
(
"*rhs*"
+
tempNamesStartIndex
);
...
...
@@ -301,7 +299,7 @@ abstract class ReplacementNode extends OperatorNode {
update
.
execute
(
frame
);
}
targetWrite
.
execute
(
frame
,
targetTmpRemove
.
execute
(
frame
)
)
;
targetTmpRemove
.
execute
(
frame
);
removeRhs
.
execute
(
frame
);
visibility
.
execute
(
frame
,
false
);
return
rhsValue
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment